Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 440026: Speed up presubmit cpplint checking by skipping unchanged files (Closed)

Created:
11 years ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

A cache of MD5 sums of source file contents is now maintained. Cpplint is only invoked for new, changed, and files containing errors from the past lint check run. As a result, repetitive presubmit checks now run in a blink of an eye, so we can include it as an obligatory pre-submit check to avoid frequent CB breakages on lint errors. Committed: http://code.google.com/p/v8/source/detail?r=3368

Patch Set 1 #

Patch Set 2 : Now works great #

Patch Set 3 : Fix error #

Patch Set 4 : Works on Windows #

Patch Set 5 : Minor corrections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -3 lines) Patch
M tools/presubmit.py View 1 2 3 4 4 chunks +68 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
11 years ago (2009-11-26 10:00:40 UTC) #1
Mads Ager (chromium)
11 years ago (2009-11-26 10:05:32 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698