Issue 440018: Ruby for NaCl. Please assign the appropriate reviewer.

Issue 440018: Ruby for NaCl. Please assign the appropriate reviewer. (Closed)

Created:
11 years ago by krasin

Modified:
9 years, 7 months ago

Reviewers:
Mark Seaborn, robertm, Brad Chen

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient.googlecode.com/svn/trunk/src/native_client/

Visibility:
Public.

Description

Committed: http://code.google.com/p/nativeclient/source/detail?r=1053

Patch Set 11 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+450 lines, -0 lines)			Patch
A	tests/ruby/Makefile	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+94 lines, -0 lines	0 comments	Download
A	tests/ruby/README	View	1 2 3 4 5 6 7 8 9	1 chunk	+40 lines, -0 lines	0 comments	Download
A	tests/ruby/appendix/config.h	View	1 2 3 4 5 6	1 chunk	+120 lines, -0 lines	0 comments	Download
A	tests/ruby/appendix/ext/Setup	View	1 2 3 4 5 6	1 chunk	+34 lines, -0 lines	0 comments	Download
A	tests/ruby/appendix/signal_missing.c	View	1 2 3 4 5 6	1 chunk	+14 lines, -0 lines	0 comments	Download
A	tests/ruby/main.c	View	1 2 3 4 5 6 7	1 chunk	+60 lines, -0 lines	0 comments	Download
A	tests/ruby/ruby.html	View	1 2 3 4 5 6	1 chunk	+26 lines, -0 lines	0 comments	Download
A	tests/ruby/ruby.js	View		1 chunk	+49 lines, -0 lines	0 comments	Download
A	tests/ruby/stdin	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	tests/ruby/stdout_golden	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

robertm

initial comments below. Please make sure all/most files have copyright headers and find a legit ...

11 years ago (2009-11-25 15:49:55 UTC) #2

Brad Chen

It's great to see this, and also great to see that it's so simple! Sorry ...

11 years ago (2009-11-25 16:19:26 UTC) #3

krasin

On 2009/11/25 16:19:26, Brad Chen wrote: > It's great to see this, and also great ...

11 years ago (2009-11-26 16:24:56 UTC) #4

krasin

http://codereview.chromium.org/440018/diff/3004/2014 File tests/ruby/Makefile (right): http://codereview.chromium.org/440018/diff/3004/2014#newcode23 tests/ruby/Makefile:23: NACL_INCLUDE = -I$(GOOGLE_CLIENT)/third_party/npapi/files/include -I$(GOOGLE_CLIENT)/native_client/tests/ruby/$(RUBY_DIR)/ On 2009/11/25 15:49:55, robertm wrote: ...

11 years ago (2009-11-26 16:25:12 UTC) #5

krasin

http://codereview.chromium.org/440018/diff/3004/2015 File tests/ruby/README (right): http://codereview.chromium.org/440018/diff/3004/2015#newcode25 tests/ruby/README:25: 6. Try Ruby queries like: On 2009/11/26 16:25:12, krasin ...

11 years ago (2009-11-30 14:43:57 UTC) #6

robertm

LGTM Thanks, this looks very nice! One small nit below. Submit after fixing it. http://codereview.chromium.org/440018/diff/13004/13011 ...

11 years ago (2009-11-30 16:37:26 UTC) #7

krasin

http://codereview.chromium.org/440018/diff/13004/13011 File tests/ruby/Makefile (right): http://codereview.chromium.org/440018/diff/13004/13011#newcode85 tests/ruby/Makefile:85: ftp://ftp.ruby-lang.org/pub/ruby/1.8/ruby-1.8.6-p368.tar.gz ruby.tgz On 2009/11/30 16:37:27, robertm wrote: > put ...

11 years ago (2009-11-30 16:50:31 UTC) #8

Mark Seaborn

11 years ago (2009-12-01 10:25:59 UTC) #9

This change got committed to SVN with an empty commit message.  In the future
can you make sure changes have a description?

Thanks,
Mark

Expand Messages | Collapse Messages