Issue 440016: Xcode project: add fast-codegen sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 440016: Xcode project: add fast-codegen sources. (Closed)

Created:
11 years ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Visibility:
Public.

Description

Xcode project: add fast-codegen sources. TBR=iposva@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=3358

Patch Set 1 #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	tools/v8.xcodeproj/project.pbxproj	View		5 chunks	+16 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

11 years ago (2009-11-25 19:21:28 UTC) #2

LGTM, but it appears that the Release v8_shell-arm build is broken.

http://codereview.chromium.org/440016/diff/1/2
File tools/v8.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/440016/diff/1/2#newcode1241
tools/v8.xcodeproj/project.pbxproj:1241: 9FBE03E210BD40EA00F8BFBA /*
fast-codegen-ia32.cc in Sources */,
We used to keep this list sorted as it reduces the potential for conflicts. But
we do not modify the Xcode project often enough for that to really matter.

http://codereview.chromium.org/440016/diff/1/2#newcode1350
tools/v8.xcodeproj/project.pbxproj:1350: 9FBE03E510BD412600F8BFBA /*
fast-codegen-arm.cc in Sources */,
ditto

Expand Messages | Collapse Messages