Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 440: Attempt at fixing crash. I believe this is happening during session... (Closed)

Created:
12 years, 3 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Attempt at fixing crash. I believe this is happening during session end, which has a different shutdown path and is possible for the model to be deleted before the view. I'm also adding checking to XPFrame/VistaFrame to make sure the BookmarkBarView doesn't have a parent in the destructor. This shouldn't be possible, but I'm adding the check to be sure;) BUG=1359852 TEST=make sure you don't see problems with bookmarks Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1754

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M chrome/browser/bookmark_bar_model.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/bookmark_bar_model.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/vista_frame.cc View 1 2 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/xp_frame.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
12 years, 3 months ago (2008-09-04 18:45:27 UTC) #1
Ben Goodger (Google)
12 years, 3 months ago (2008-09-04 22:44:44 UTC) #2
LG

Powered by Google App Engine
This is Rietveld 408576698