Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 439014: Remove -Os from gyp C++ flags if it exists, since v8 uses -O3. (Closed)

Created:
11 years, 1 month ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Mads Ager (chromium), mark
CC:
v8-dev
Visibility:
Public.

Description

Remove -Os from gyp C++ flags if it exists, since v8 uses -O3.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Evan Martin
(Review list found by looking at log) What we really want to do is strip ...
11 years, 1 month ago (2009-11-23 23:53:41 UTC) #1
Mads Ager (chromium)
LGTM I'll land this change in bleeding_edge V8. Does this change have an effect on ...
11 years, 1 month ago (2009-11-24 11:04:43 UTC) #2
Evan Martin
Inline comment describing better what I did http://codereview.chromium.org/439014/diff/1/2 File tools/gyp/v8.gyp (right): http://codereview.chromium.org/439014/diff/1/2#newcode88 tools/gyp/v8.gyp:88: '-O3', Here, ...
11 years, 1 month ago (2009-11-24 18:12:30 UTC) #3
Evan Martin
11 years, 1 month ago (2009-11-24 18:13:04 UTC) #4
(I am looking into building Chrome with -Os, but v8 won't compile with it set
anyway...)

Powered by Google App Engine
This is Rietveld 408576698