Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 4385002: Fix broken quoting in cbuildbot.py, allowing for correct revving of ebuilds. (Closed)

Created:
10 years, 1 month ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
anush, scottz, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fix broken quoting in cbuildbot.py, allowing for correct revving of ebuilds. When you pass '--foo="bar baz"' to a script, the argument is literally passed as "bar baz", with the quotes. So we need to not add unnecessary quotes in there. When enter_chroot.sh parses arguments, it actually removes the quotes for you, and splits up arguments. As a result, it may actually be necessary to (1) use the above broken syntax when you call scripts using enter_chroot.sh; but (2) don't use that syntax when calling scripts without enter_chroot.sh. That's a broken situation, so I've added a TODO for that. I've also added more warnings to cros_mark_as_stable.py so that it's easier to debug when it doesn't work. BUG=chromium-os:8633 TEST=Ran unit tests. Planning to watch TOT buildbot post-commit to make sure behavior is right. Change-Id: Ia1a0e60153fec60cb7ed4db2da128ffd9ae81e23 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1f79aaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M bin/cbuildbot.py View 4 chunks +8 lines, -4 lines 0 comments Download
M cros_mark_as_stable.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
davidjames
10 years, 1 month ago (2010-11-03 17:55:12 UTC) #1
davidjames
10 years, 1 month ago (2010-11-03 18:07:50 UTC) #2
scottz
10 years, 1 month ago (2010-11-03 18:13:41 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698