Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 4381001: Implement onDOMContentLoaded event of the webNavigation API. (Closed)

Created:
10 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
yzshen, Matt Perry
CC:
chromium-reviews, nkostylev+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Implement onDOMContentLoaded event of the webNavigation API. BUG=50943 TEST=browser_tests:*.WebNavigationEvents*,unit_tests:FrameNavigationStateTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65034

Patch Set 1 #

Total comments: 12

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -30 lines) Patch
M chrome/browser/chromeos/login/web_page_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/web_page_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.h View 1 3 chunks +19 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 1 8 chunks +64 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_unittest.cc View 1 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/notification_type.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/navigation1/test.html View 14 chunks +70 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/navigation2/test.html View 4 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
please review
10 years, 1 month ago (2010-11-03 14:47:18 UTC) #1
yzshen
http://codereview.chromium.org/4381001/diff/1/2 File chrome/browser/chromeos/login/web_page_view.cc (right): http://codereview.chromium.org/4381001/diff/1/2#newcode81 chrome/browser/chromeos/login/web_page_view.cc:81: void WizardWebPageViewTabContents::DocumentLoadedInFrame(long long frame_id) { (From Google C++ style ...
10 years, 1 month ago (2010-11-03 18:20:54 UTC) #2
Matt Perry
LGTM http://codereview.chromium.org/4381001/diff/1/2 File chrome/browser/chromeos/login/web_page_view.cc (right): http://codereview.chromium.org/4381001/diff/1/2#newcode81 chrome/browser/chromeos/login/web_page_view.cc:81: void WizardWebPageViewTabContents::DocumentLoadedInFrame(long long frame_id) { On 2010/11/03 18:20:54, ...
10 years, 1 month ago (2010-11-03 22:26:30 UTC) #3
yzshen
http://codereview.chromium.org/4381001/diff/1/2 File chrome/browser/chromeos/login/web_page_view.cc (right): http://codereview.chromium.org/4381001/diff/1/2#newcode81 chrome/browser/chromeos/login/web_page_view.cc:81: void WizardWebPageViewTabContents::DocumentLoadedInFrame(long long frame_id) { On 2010/11/03 22:26:30, Matt ...
10 years, 1 month ago (2010-11-03 22:33:01 UTC) #4
jochen (gone - plz use gerrit)
http://codereview.chromium.org/4381001/diff/1/2 File chrome/browser/chromeos/login/web_page_view.cc (right): http://codereview.chromium.org/4381001/diff/1/2#newcode81 chrome/browser/chromeos/login/web_page_view.cc:81: void WizardWebPageViewTabContents::DocumentLoadedInFrame(long long frame_id) { On 2010/11/03 22:33:02, yzshen ...
10 years, 1 month ago (2010-11-04 08:44:57 UTC) #5
yzshen
10 years, 1 month ago (2010-11-04 16:45:41 UTC) #6
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698