Issue 438012: Call git diff --name-status with a relative path....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438012: Call git diff --name-status with a relative path.... (Closed)

Created:
11 years, 1 month ago by chase

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, Evan Martin

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Call git diff --name-status with a relative path. On a new Linux box, during git cl dcommit I observed the error: fatal: invalid diff option/value: -r This was caused by the git cl presubmit hooks running: git diff --name-status -r refs/remotes/origin/trunk.. /path/to/src By passing a relative path (given by git rev-parse --show-cdup) instead of an absolute path for /path/to/src, git diff --name-status does not print an error and returns the expected list of changed files. Also fix some broken scm and gclient_scm unit tests. BUG=none TEST=git presubmit hooks work from main working directory Committed as r32999

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
M	git_cl_hooks.py	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	tests/gclient_scm_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/scm_unittest.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chase

11 years, 1 month ago (2009-11-24 23:33:59 UTC) #3

On 2009/11/24 02:21:06, Marc-Antoine Ruel wrote:
> lgtm
> 
> sorry for the unit test

got lgtm from evanm over im, and it seems like we all agree this is weird.  i
will monitor feedback for any issues.

Expand Messages | Collapse Messages

Issue 438012: Call git diff --name-status with a relative path.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages