Mac Sandbox: Clean up forward declaration of internal sandbox functions.

Mac Sandbox: Clean up forward declaration of internal sandbox functions.

Move all Sandbox functions into their own class and declare functions needed by tests as private with FRIEND_TEST declarations where appropriate.

BUG=60917
TEST=Chrome on Mac should run and unit tests should pass.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65332

[Mark Mentovai, 2010-11-04 16:19:29]

LGTM

http://codereview.chromium.org/4380001/diff/3001/4001
File chrome/common/sandbox_init_wrapper_mac.cc (right):

http://codereview.chromium.org/4380001/diff/3001/4001#newcode1
chrome/common/sandbox_init_wrapper_mac.cc:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
CL description: “clean up” as a verb is two words.

http://codereview.chromium.org/4380001/diff/3001/4002
File chrome/common/sandbox_mac.h (right):

http://codereview.chromium.org/4380001/diff/3001/4002#newcode58
chrome/common/sandbox_mac.h:58: SandboxVariableSubstitions;
The hanging continuation indent is 4 spaces.

http://codereview.chromium.org/4380001/diff/3001/4002#newcode65
chrome/common/sandbox_mac.h:65: // The worker processes uses the most
restrictive sandbox which has almost
“processes use” or “process uses.”

http://codereview.chromium.org/4380001/diff/3001/4002#newcode120
chrome/common/sandbox_mac.h:120: // The ;10.6_ONLY comment can then be removed
from the template to enable (foo)
80

http://codereview.chromium.org/4380001/diff/3001/4002#newcode143
chrome/common/sandbox_mac.h:143: // Escape |str_utf8| for use in a plain string
variable in a sandbox
In these functions, str_utf8 doesn’t seem like a great name. Why isn’t the dst
parameter named dst_utf8? If you have a dst, why don’t you have a src?

http://codereview.chromium.org/4380001/diff/3001/4002#newcode173
chrome/common/sandbox_mac.h:173: DISALLOW_COPY_AND_ASSIGN(Sandbox);
Use DISALLOW_IMPLICIT_CONSTRUCTORS on this one instead.