Issue 4379001: Suppress a test-only data race in ipc_tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4379001: Suppress a test-only data race in ipc_tests... (Closed)

Created:
10 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress a test-only data race in ipc_tests BUG=61731 TBR=glider TEST=TSan/Mac should go green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64905

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	tools/valgrind/tsan/suppressions.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 1 month ago (2010-11-03 14:08:30 UTC) #2

LGTM

On Wed, Nov 3, 2010 at 4:19 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Suppress a test-only data race in ipc_tests
> BUG=61731
> TBR=glider
> TEST=TSan/Mac should go green
>
> Please review this at http://codereview.chromium.org/4379001/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/tsan/suppressions.txt
>
>
> Index: tools/valgrind/tsan/suppressions.txt
> ===================================================================
> --- tools/valgrind/tsan/suppressions.txt        (revision 64747)
> +++ tools/valgrind/tsan/suppressions.txt        (working copy)
> @@ -166,6 +166,16 @@
>   fun:*WorkerThreadTickerTest_LongCallback_Test*TestBody*
>  }
>
> +{
> +  bug_61731
> +  ThreadSanitizer:Race
> +  fun:*Log*
> +  ...
> +  fun:*Worker*
> +  ...
> +  obj:*ipc_tests
> +}
> +
>  # TODO(timurrrr): bug item
>  {
>   Data race on bool in AssertReporter [test-only]
>
>
>

Expand Messages | Collapse Messages