Issue 4374002: Suppress an UninitCondition bug in v8::internal::preparser...

Issue 4374002: Suppress an UninitCondition bug in v8::internal::preparser... (Closed)

Created:
10 years, 1 month ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
antonm

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress an UninitCondition bug in v8::internal::preparser BUG=61737 TBR=antonm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64909

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

10 years, 1 month ago (2010-11-03 14:13:00 UTC) #2

LGTM

On Wed, Nov 3, 2010 at 5:11 PM,  <glider@chromium.org> wrote:
> Reviewers: antonm,
>
> Message:
> TBR
>
> Description:
> Suppress an UninitCondition bug in v8::internal::preparser
>
> BUG=61737
> TBR=antonm
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64909
>
> Please review this at http://codereview.chromium.org/4374002/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions_mac.txt
>
>
> Index: tools/valgrind/memcheck/suppressions_mac.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions_mac.txt        (revision 64907)
> +++ tools/valgrind/memcheck/suppressions_mac.txt        (working copy)
> @@ -1080,3 +1080,22 @@
>
>
 fun:_ZN7testingL35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS3_FS2_vEPKc
>  }
>
> +{
> +   bug_61737
> +   Memcheck:Cond
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE36ParseMemberWithNewPrefixesExpressionEPiPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE14ParseNewPrefixEPiPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE18ParseNewExpressionEPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE27ParseLeftHandSideExpressionEPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE22ParsePostfixExpressionEPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE20ParseUnaryExpressionEPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE21ParseBinaryExpressionEibPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE26ParseConditionalExpressionEbPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE25ParseAssignmentExpressionEbPb
> +   ...
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE19ParseSourceElementsEiPb
> +
>
fun:_ZN2v88internal9preparser9PreParserINS0_7ScannerENS0_21PartialParserRecorderEE15PreParseProgramEPS3_PS4_b
> +
>
fun:_ZN2v88internal9ParserApi15PartialPreParseENS0_6HandleINS0_6StringEEEPN7unibrow15CharacterStreamEPNS_9ExtensionE
> +
>
fun:_ZN2v88internal8Compiler7CompileENS0_6HandleINS0_6StringEEENS2_INS0_6ObjectEEEiiPNS_9ExtensionEPNS0_14ScriptDataImplES6_NS0_11NativesFlagE
> +}
> +
>
>
>

Expand Messages | Collapse Messages