Issue 4371001: Fix clang build by moving ToLowerASCII into base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4371001: Fix clang build by moving ToLowerASCII into base namespace. (Closed)

Created:
10 years, 1 month ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, davemoore+watch_chromium.org, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix clang build by moving ToLowerASCII into base namespace. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64879

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	base/string_util.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	base/string_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/vector_canvas_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

On 2010/11/03 04:18:46, Nico wrote: > LG with green trybots. > > Thanks! Nico, linux ...

10 years, 1 month ago (2010-11-03 04:56:17 UTC) #3

Nico

10 years, 1 month ago (2010-11-03 05:31:27 UTC) #4

On Wed, Nov 3, 2010 at 12:56 AM,  <tfarina@chromium.org> wrote:
> On 2010/11/03 04:18:46, Nico wrote:
>>
>> LG with green trybots.
>
>> Thanks!
>
> Nico, linux and windows compiled. I'm going to apply this now without
> waiting
> them to finish. It's pretty late here, and I need some sleep.

The clang bot cycled green, thanks.

Expand Messages | Collapse Messages