Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 437081: Added fast compiler support for calling JS runtime functions.... (Closed)

Created:
11 years ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added fast compiler support for calling JS runtime functions. Also added a simple test that invokes a JS runtime function in top-level code. Committed: http://code.google.com/p/v8/source/detail?r=3371

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -14 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 2 2 chunks +21 lines, -4 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 2 2 chunks +20 lines, -4 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 2 2 chunks +19 lines, -4 lines 0 comments Download
A test/mjsunit/compiler/jsnatives.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
Here's a small addition to the fast compiler. Is test-compiler.cc the right place for testing ...
11 years ago (2009-11-26 08:34:03 UTC) #1
Lasse Reichstein
LGTM. You can have an mjsunit test that allows native syntax by adding a comment ...
11 years ago (2009-11-26 10:37:44 UTC) #2
fschneider
11 years ago (2009-11-27 00:27:09 UTC) #3
I added a separate mjsunit test now.

http://codereview.chromium.org/437081/diff/1/4
File src/compiler.cc (left):

http://codereview.chromium.org/437081/diff/1/4#oldcode983
src/compiler.cc:983: if (expr->function() == NULL) BAILOUT("call JS runtime
function");
On 2009/11/26 10:37:44, Lasse Reichstein wrote:
> On general principle, could we put an is_js_runtime_function method on
> CallRuntime that tested the function against NULL, instead of having to know
the
> significance of a NULL function everywhere?
> The name probably needs work.

Done.

Powered by Google App Engine
This is Rietveld 408576698