Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 437071: Use new CJK Vista fonts for DOM UI by listing them in IDS_WEB_FONT_FAMILY bef... (Closed)

Created:
11 years ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy, glen
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use new CJK Vista fonts for DOM UI by listing them in IDS_WEB_FONT_FAMILY before the old CJK Win fonts (available on Win XP, Vista / 7). Vista fonts are better looking that the old CJK fonts. Also, list Arial at the beginning so that Arial is used for the 'ASCII portion' than not-so-nice glyphs for the ASCII portion in CJK fonts. BUG=NONE TEST=1. On Win Vista/7, run Chrome with '--lang=zh-CN' (zh-TW, ja and ko). The font in DOM UI (history, download, new tab) look nicer than on WIn XP. 2. Even on XP, the ASCII portion (Latin letters and numbers) in CJK Chrome looks nicer than before in DOM UI pages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/app/resources/locale_settings_ja.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_ko.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_zh-CN.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_zh-TW.xtb View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
11 years ago (2009-11-25 22:13:03 UTC) #1
Glen Murphy
11 years ago (2009-11-30 21:36:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698