Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 437052: Fixed incorrect instruction usage in KeyedLoadIC for byte and word... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/ic-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 381
382 // eax: untagged index 382 // eax: untagged index
383 // ecx: elements array 383 // ecx: elements array
384 __ mov(ecx, FieldOperand(ecx, ExternalArray::kExternalPointerOffset)); 384 __ mov(ecx, FieldOperand(ecx, ExternalArray::kExternalPointerOffset));
385 // ecx: base pointer of external storage 385 // ecx: base pointer of external storage
386 switch (array_type) { 386 switch (array_type) {
387 case kExternalByteArray: 387 case kExternalByteArray:
388 __ movsx_b(eax, Operand(ecx, eax, times_1, 0)); 388 __ movsx_b(eax, Operand(ecx, eax, times_1, 0));
389 break; 389 break;
390 case kExternalUnsignedByteArray: 390 case kExternalUnsignedByteArray:
391 __ mov_b(eax, Operand(ecx, eax, times_1, 0)); 391 __ movzx_b(eax, Operand(ecx, eax, times_1, 0));
392 break; 392 break;
393 case kExternalShortArray: 393 case kExternalShortArray:
394 __ movsx_w(eax, Operand(ecx, eax, times_2, 0)); 394 __ movsx_w(eax, Operand(ecx, eax, times_2, 0));
395 break; 395 break;
396 case kExternalUnsignedShortArray: 396 case kExternalUnsignedShortArray:
397 __ mov_w(eax, Operand(ecx, eax, times_2, 0)); 397 __ movzx_w(eax, Operand(ecx, eax, times_2, 0));
398 break; 398 break;
399 case kExternalIntArray: 399 case kExternalIntArray:
400 case kExternalUnsignedIntArray: 400 case kExternalUnsignedIntArray:
401 __ mov(eax, Operand(ecx, eax, times_4, 0)); 401 __ mov(eax, Operand(ecx, eax, times_4, 0));
402 break; 402 break;
403 case kExternalFloatArray: 403 case kExternalFloatArray:
404 __ fld_s(Operand(ecx, eax, times_4, 0)); 404 __ fld_s(Operand(ecx, eax, times_4, 0));
405 break; 405 break;
406 default: 406 default:
407 UNREACHABLE(); 407 UNREACHABLE();
(...skipping 954 matching lines...) Expand 10 before | Expand all | Expand 10 after
1362 1362
1363 // Do tail-call to runtime routine. 1363 // Do tail-call to runtime routine.
1364 __ TailCallRuntime( 1364 __ TailCallRuntime(
1365 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3, 1); 1365 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3, 1);
1366 } 1366 }
1367 1367
1368 #undef __ 1368 #undef __
1369 1369
1370 1370
1371 } } // namespace v8::internal 1371 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/x64/ic-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698