Issue 437052: Fixed incorrect instruction usage in KeyedLoadIC for byte and word...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 437052: Fixed incorrect instruction usage in KeyedLoadIC for byte and word... (Closed)

Created:
11 years, 1 month ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
iposva, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed incorrect instruction usage in KeyedLoadIC for byte and word external array types. Added regression test based on real-world failing code and verified that it would have caught this error. Committed: http://code.google.com/p/v8/source/detail?r=3366

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -3 lines)			Patch
M	src/ia32/ic-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Still LGTM. -ip

Expand Messages | Collapse Messages