Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/browser/password_manager/password_form_manager.h

Issue 437032: Fixed handling of preferred login info in password manager. (Closed)
Patch Set: Fixed handling of preferred login info in password manager. Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_form_manager.h
diff --git a/chrome/browser/password_manager/password_form_manager.h b/chrome/browser/password_manager/password_form_manager.h
index fe6ceeec76c6feb42be76452848368cb902973ed..5fe7d269178319416c19a59cbb0e72028b77c598 100644
--- a/chrome/browser/password_manager/password_form_manager.h
+++ b/chrome/browser/password_manager/password_form_manager.h
@@ -92,8 +92,9 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Helper for Save in the case that best_matches.size() == 0, meaning
// we have no prior record of this form/username/password and the user
- // has opted to 'Save Password'.
- void SaveAsNewLogin();
+ // has opted to 'Save Password'. If |reset_preferred_login| is set,
+ // the previously preferred login from |best_matches_| will be reset.
+ void SaveAsNewLogin(bool reset_preferred_login);
// Helper for OnWebDataServiceRequestDone to score an individual result
// against the observed_form_.
@@ -106,6 +107,11 @@ class PasswordFormManager : public PasswordStoreConsumer {
// is now implicitly 'preferred'.
void UpdateLogin();
+ // Update all login matches to reflect new preferred state - preferred flag
+ // will be reset on all matched logins that different than the current
+ // |pending_credentials_|.
+ void UpdatePreferredLoginState(PasswordStore* password_store);
+
// Set of PasswordForms from the DB that best match the form
// being managed by this. Use a map instead of vector, because we most
// frequently require lookups by username value in IsNewLogin.
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698