Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 437004: Store API callback entry address prior to entering a callback. (Closed)

Created:
11 years, 1 month ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Store API callback entry address prior to entering a callback. Callback entry address is stored in VMState and is later retrieved by profiler stack sampler. This makes possible relating API entry to JS stack, and this is simpler than trying to unwind native stack. Committed: http://code.google.com/p/v8/source/detail?r=3344

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M src/builtins.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/log.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/log.cc View 2 chunks +8 lines, -2 lines 2 comments Download
M src/log-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
11 years, 1 month ago (2009-11-23 14:25:40 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/437004/diff/1/4 File src/log.cc (right): http://codereview.chromium.org/437004/diff/1/4#newcode159 src/log.cc:159: const Address callback = Logger::current_state_ ? Please use ...
11 years, 1 month ago (2009-11-23 14:35:12 UTC) #2
mnaganov (inactive)
11 years, 1 month ago (2009-11-23 14:42:26 UTC) #3
Thanks!

http://codereview.chromium.org/437004/diff/1/4
File src/log.cc (right):

http://codereview.chromium.org/437004/diff/1/4#newcode159
src/log.cc:159: const Address callback = Logger::current_state_ ?
On 2009/11/23 14:35:12, Søren Gjesse wrote:
> Please use Logger::current_state_ != NULL.

Done.

Powered by Google App Engine
This is Rietveld 408576698