Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 4369001: Add proxies for Var deprecated and some additional tracking information. The... (Closed)

Created:
10 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Add proxies for Var deprecated and some additional tracking information. These don't build by themselves, this is part of a larger patch. You can see most of the serialization mechanics already checked in to the same directory. TEST=none BUG=none Committed: http://code.google.com/p/ppapi/source/detail?r=64955

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+690 lines, -0 lines) Patch
A ppapi/proxy/plugin_var_tracker.h View 1 chunk +76 lines, -0 lines 2 comments Download
A ppapi/proxy/plugin_var_tracker.cc View 1 chunk +134 lines, -0 lines 1 comment Download
A ppapi/proxy/ppb_var_deprecated_proxy.h View 1 chunk +95 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_var_deprecated_proxy.cc View 1 chunk +385 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
brettw
10 years, 1 month ago (2010-11-03 03:44:25 UTC) #1
jam
10 years, 1 month ago (2010-11-03 17:21:22 UTC) #2
lgtm with these nits

http://codereview.chromium.org/4369001/diff/1/2
File ppapi/proxy/plugin_var_tracker.cc (right):

http://codereview.chromium.org/4369001/diff/1/2#newcode125
ppapi/proxy/plugin_var_tracker.cc:125: INTERFACE_ID_PPB_VAR_DEPRECATED, id));
nit: here and below, 2 extra spaces

http://codereview.chromium.org/4369001/diff/1/3
File ppapi/proxy/plugin_var_tracker.h (right):

http://codereview.chromium.org/4369001/diff/1/3#newcode23
ppapi/proxy/plugin_var_tracker.h:23: // a single ref in the browser process
whenever we have a nonzero refcount
browser->renderer to match the cc file?

http://codereview.chromium.org/4369001/diff/1/3#newcode62
ppapi/proxy/plugin_var_tracker.h:62: // When !is_plugin_ (we're in the renderer)
this points to the actual var
there's no is_plugin_ here?

http://codereview.chromium.org/4369001/diff/1/4
File ppapi/proxy/ppb_var_deprecated_proxy.cc (right):

http://codereview.chromium.org/4369001/diff/1/4#newcode274
ppapi/proxy/ppb_var_deprecated_proxy.cc:274: // FIXME(brettw) handle bad
messages!
nit: now that this is in chrome repo, shouldn't it be TODO?

Powered by Google App Engine
This is Rietveld 408576698