Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 4366001: base: Move CaseInsensitiveCompare traits into the base namespace. (Closed)

Created:
10 years, 1 month ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
brettw, Jeff Timanus
CC:
chromium-reviews, cbentzel+watch_chromium.org, amit, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

base: Move CaseInsensitiveCompare traits into the base namespace. This should fix conflicts like: 2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope 2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare' Reported-by: Jeff Timanus <twiz@google.com>; BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M base/string_util.h View 2 chunks +18 lines, -17 lines 0 comments Download
M base/string_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome_frame/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_response_headers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
+brett for review. +jeff FYI.
10 years, 1 month ago (2010-11-03 02:37:21 UTC) #1
brettw
10 years, 1 month ago (2010-11-03 02:40:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698