Issue 4365001: Use optimized scrolling for pepper plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4365001: Use optimized scrolling for pepper plugins. (Closed)

Created:
10 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use optimized scrolling for pepper plugins. BUG=49551 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64952

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -14 lines)			Patch
M	chrome/renderer/render_widget_fullscreen_pepper.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_fullscreen_container.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_graphics_2d.cc	View	2 chunks	+22 lines, -14 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.cc	View	1 chunk	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 1 month ago (2010-11-03 01:16:40 UTC) #2

LGTM

http://codereview.chromium.org/4365001/diff/1/5
File webkit/glue/plugins/pepper_plugin_instance.cc (right):

http://codereview.chromium.org/4365001/diff/1/5#newcode368
webkit/glue/plugins/pepper_plugin_instance.cc:368: // Can't do optimized
scrolling since there could be other elemetns on top
elemetns -> elements

Expand Messages | Collapse Messages