Add change to enable getting safe build of chrome

Add change to enable getting safe build of chrome


Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=318

[sosa, 2009-11-24 23:49:55]

Add flag to build_platform_packages to allow copy_chrome_zip to optionally pull
tested zip of browser.  Also can send -s flag to copy_chrome_zip to enable as
well

[Randall Spangler, 2009-11-25 00:21:31]

http://codereview.chromium.org/436035/diff/1/2
File src/platform/chrome/copy_chrome_zip.sh (right):

http://codereview.chromium.org/436035/diff/1/2#newcode25
src/platform/chrome/copy_chrome_zip.sh:25: WGET_SAFE_BUILD=$GET_SAFE_CHROME
SAFE --> STABLE

("safe" may be too strong a word)

http://codereview.chromium.org/436035/diff/1/2#newcode106
src/platform/chrome/copy_chrome_zip.sh:106: echo "Using locally-build Chrome
from $LOCAL_CHROME"
build -> built

http://codereview.chromium.org/436035/diff/1/3
File src/scripts/build_platform_packages.sh (right):

http://codereview.chromium.org/436035/diff/1/3#newcode15
src/scripts/build_platform_packages.sh:15: DEFINE_boolean safe $FLAGS_FALSE
"Build with safe version of browser."
safe --> stable

http://codereview.chromium.org/436035/diff/1/3#newcode29
src/scripts/build_platform_packages.sh:29: PLATFORM_DIRS="chrome"
Leftover debugging code?  Gets overwritten by line 31...

[sosa, 2009-11-25 00:47:37]

http://codereview.chromium.org/436035/diff/1/2
File src/platform/chrome/copy_chrome_zip.sh (right):

http://codereview.chromium.org/436035/diff/1/2#newcode25
src/platform/chrome/copy_chrome_zip.sh:25: WGET_SAFE_BUILD=$GET_SAFE_CHROME
On 2009/11/25 00:21:31, Randall Spangler wrote:
> SAFE --> STABLE
> 
> ("safe" may be too strong a word)

Done.

http://codereview.chromium.org/436035/diff/1/2#newcode106
src/platform/chrome/copy_chrome_zip.sh:106: echo "Using locally-build Chrome
from $LOCAL_CHROME"
On 2009/11/25 00:21:31, Randall Spangler wrote:
> build -> built

Good catch!  Pre-existing but I made sure to fix other tenses

http://codereview.chromium.org/436035/diff/1/3
File src/scripts/build_platform_packages.sh (right):

http://codereview.chromium.org/436035/diff/1/3#newcode15
src/scripts/build_platform_packages.sh:15: DEFINE_boolean safe $FLAGS_FALSE
"Build with safe version of browser."
On 2009/11/25 00:21:31, Randall Spangler wrote:
> safe --> stable

Done.

http://codereview.chromium.org/436035/diff/1/3#newcode29
src/scripts/build_platform_packages.sh:29: PLATFORM_DIRS="chrome"
On 2009/11/25 00:21:31, Randall Spangler wrote:
> Leftover debugging code?  Gets overwritten by line 31...

Done.

[Randall Spangler, 2009-11-25 01:06:29]

lgtm