Implement method stubs for OpenMAX IL instead of relying on -lOmxCore.

Implement method stubs for OpenMAX IL instead of relying on -lOmxCore.

You can switch to using -lOmxCore by setting the gyp variable use_system_openmax=1.

BUG=28663
TEST=building omx_test should have no linker errors

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32988

[awong, 2009-11-24 11:31:26]

http://codereview.chromium.org/436021/diff/2001/3002
File media/media.gyp (right):

http://codereview.chromium.org/436021/diff/2001/3002#newcode252
media/media.gyp:252: 'omx/omx_video_decoder.cc',
This should be split up into a n omx_decoder library which is separate from the
pure test drivers.  Not sure if there's a better name.

BTW, omx_video_decoder has a naming clash clash with the natural class-name for
a the media filter (FFmpegVideoDecoder -> OmxVideoDecoder = Clash).  Any
suggestion on a better name wuld be appreciated.

[scherkus (not reviewing), 2009-11-24 18:41:34]

http://codereview.chromium.org/436021/diff/2001/3002
File media/media.gyp (right):

http://codereview.chromium.org/436021/diff/2001/3002#newcode252
media/media.gyp:252: 'omx/omx_video_decoder.cc',
On 2009/11/24 11:31:26, awong wrote:
> This should be split up into a n omx_decoder library which is separate from
the
> pure test drivers.  Not sure if there's a better name.
> 
> BTW, omx_video_decoder has a naming clash clash with the natural class-name
for
> a the media filter (FFmpegVideoDecoder -> OmxVideoDecoder = Clash).  Any
> suggestion on a better name wuld be appreciated.

OMXVideoDecoder :P

Jokes aside, this was copied straight from the now defunct omx_test.gyp, so I'm
inclined to leave it be for a very-short-time until I can do the massive /media
restructuring (mostly moving stuff into /tools)

I'm also thinking omx code might have an omx namespace

..but I completely agree with you about the library!

[awong, 2009-11-24 18:57:14]

LGTM

[Alpha Left Google, 2009-11-24 19:12:40]

LGTM

[scherkus (not reviewing), 2009-11-24 22:09:34]

might want to take one more quick look for fixes to windows

[awong, 2009-11-24 22:10:42]

LGTM

Bah...stupid x-platform.

[Alpha Left Google, 2009-11-24 22:13:35]

LGTM.