Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: trychange.py

Issue 4360002: Largely reduce the number of pylint warnings and fix one typo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: address comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/presubmit_unittest.py ('k') | watchlists.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 5d73cb71d0ec272784c7e2f2a02cfafcfbd72dad..d560a78fa122ba4c9f876240555ddad833bbc751 100755
--- a/trychange.py
+++ b/trychange.py
@@ -2,6 +2,7 @@
# Copyright (c) 2009 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+
"""Client-side script to send a try job to the try server. It communicates to
the try server by either writting to a svn repository or by directly connecting
to the server by HTTP.
@@ -29,7 +30,7 @@ except ImportError:
json = None
try:
- import breakpad
+ import breakpad # pylint: disable=W0611
except ImportError:
pass
@@ -205,11 +206,9 @@ class SVN(SCM):
return data
# Try to search on the subversion repository for the file.
- try:
- from gcl import GetCachedFile
- except ImportError:
+ if not gcl:
return None
- data = GetCachedFile(filename)
+ data = gcl.GetCachedFile(filename)
logging.debug('%s:\n%s' % (filename, data))
return data
« no previous file with comments | « tests/presubmit_unittest.py ('k') | watchlists.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698