Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 4349002: Revert 64687 - Try to detect internal corruption of histogram instances.... (Closed)

Created:
10 years, 1 month ago by jar (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 64687 - Try to detect internal corruption of histogram instances. Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -242 lines) Patch
M base/metrics/histogram.h View 12 chunks +5 lines, -56 lines 0 comments Download
M base/metrics/histogram.cc View 21 chunks +9 lines, -97 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/common/metrics_helpers.cc View 1 chunk +1 line, -17 lines 0 comments Download
M chrome/renderer/renderer_histogram_snapshots.cc View 2 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jar (doing other things)
10 years, 1 month ago (2010-11-02 23:28:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698