Issue 4347003: sync: on chrome os, postpone network reachability check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4347003: sync: on chrome os, postpone network reachability check (Closed)

Created:
10 years, 1 month ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/debug

Visibility:
Public.

Description

sync: on chrome os, postpone network reachability check Incur a delay of 5 seconds to reduce probability of of blocking shutdown on an http request. This is intended to be a temporary workaround hack. BUG=chromium-os:8429 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64958

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	chrome/browser/sync/engine/syncapi.cc	View	1	3 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

akalin

LGTM http://codereview.chromium.org/4347003/diff/1/2 File chrome/browser/sync/engine/syncapi.cc (right): http://codereview.chromium.org/4347003/diff/1/2#newcode1737 chrome/browser/sync/engine/syncapi.cc:1737: #endif // #if defined(OS_CHROMEOS) comment shouldn't have "#if"

10 years, 1 month ago (2010-11-03 00:22:13 UTC) #2

tim (not reviewing)

10 years, 1 month ago (2010-11-03 00:27:12 UTC) #3

waiting for green cros try runs to land.

http://codereview.chromium.org/4347003/diff/1/2
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/4347003/diff/1/2#newcode1737
chrome/browser/sync/engine/syncapi.cc:1737: #endif  // #if defined(OS_CHROMEOS)
On 2010/11/03 00:22:13, akalin wrote:
> comment shouldn't have "#if"

Done.

Expand Messages | Collapse Messages