Issue 4347001: [ChromeOS] Hardcoded screen lock enabled for google.com users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4347001: [ChromeOS] Hardcoded screen lock enabled for google.com users. (Closed)

Created:
10 years, 1 month ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[ChromeOS] Hardcoded screen lock enabled for google.com users. This is a sad change that we have to hard code this. :( And hopefully, we will get the enterprise feature complete soon and could remove this hack. BUG=none. TEST=Verify that screen lock is enabled for google.com logins. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64992

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix a bug per zel #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/browser/chromeos/login/login_utils.cc	View	1	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zel

BUG please! http://codereview.chromium.org/4347001/diff/1/2 File chrome/browser/chromeos/login/login_utils.cc (right): http://codereview.chromium.org/4347001/diff/1/2#newcode246 chrome/browser/chromeos/login/login_utils.cc:246: if (EndsWith(username, "google.com", true)) { EndsWith(username, "@google.com", ...

10 years, 1 month ago (2010-11-03 00:22:38 UTC) #2

xiyuan

http://codereview.chromium.org/4347001/diff/1/2 File chrome/browser/chromeos/login/login_utils.cc (right): http://codereview.chromium.org/4347001/diff/1/2#newcode246 chrome/browser/chromeos/login/login_utils.cc:246: if (EndsWith(username, "google.com", true)) { On 2010/11/03 00:22:38, zel ...

10 years, 1 month ago (2010-11-03 16:06:37 UTC) #3

LGTM

Expand Messages | Collapse Messages