Add proxies for core and class (for calling from WebKit to the plugin). These...

Add proxies for core and class (for calling from WebKit to the plugin). These
don't build by themselves, this is part of a larger patch. You can see most of
the serialization mechanics already checked in to the same directory.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65261

[brettw, 2010-11-03 03:33:51]

This is my first pass of "mostly working" proxies.

[brettw, 2010-11-05 03:40:18]

Ping

[viettrungluu, 2010-11-05 17:46:41]

Oops. Sorry for the delay.

Here are some super-superficial comments while I try to wrap my head around
this.

http://codereview.chromium.org/4345003/diff/1/2
File ppapi/proxy/ppb_core_proxy.cc (right):

http://codereview.chromium.org/4345003/diff/1/2#newcode117
ppapi/proxy/ppb_core_proxy.cc:117: *result = 0.0;  // FIXME(brettw);
?

http://codereview.chromium.org/4345003/diff/1/3
File ppapi/proxy/ppb_core_proxy.h (right):

http://codereview.chromium.org/4345003/diff/1/3#newcode37
ppapi/proxy/ppb_core_proxy.h:37: void OnMsgCallOnMainThread(int delay_in_msec,
Nit: "ms" is the standard abbreviation for millisecond(s).

http://codereview.chromium.org/4345003/diff/1/4
File ppapi/proxy/ppp_class_proxy.cc (right):

http://codereview.chromium.org/4345003/diff/1/4#newcode75
ppapi/proxy/ppp_class_proxy.cc:75: // FIXME
Did you want to do this now (or turn it into a TODO(brettw))?

http://codereview.chromium.org/4345003/diff/1/4#newcode252
ppapi/proxy/ppp_class_proxy.cc:252: // FIXME
Ditto.

[viettrungluu, 2010-11-05 18:22:17]

I have no other comments other than that having to proxy GetTime/GetTimeTicks
seems kind of suboptimal.

It mostly looks okay to me (other than the FIXMEs), though I'm sure I've missed
something....

http://codereview.chromium.org/4345003/diff/1/2
File ppapi/proxy/ppb_core_proxy.cc (right):

http://codereview.chromium.org/4345003/diff/1/2#newcode39
ppapi/proxy/ppb_core_proxy.cc:39: PluginDispatcher::Get()->Send(new
PpapiHostMsg_PPBCore_GetTime(
Is it really going to be necessary to proxy GetTime and GetTimeTicks?

http://codereview.chromium.org/4345003/diff/1/2#newcode54
ppapi/proxy/ppb_core_proxy.cc:54: Dispatcher* dispatcher =
PluginDispatcher::Get();
And CallOnMainThread?

http://codereview.chromium.org/4345003/diff/1/2#newcode123
ppapi/proxy/ppb_core_proxy.cc:123: // TODO(brettw) this doesn't need to go to
the other process, we should be
Yeah.

[brettw, 2010-11-05 18:45:19]

More complete patch uploaded. This should address everything.

[viettrungluu, 2010-11-05 18:55:33]

LGTM.