Issue 4343002: A recent change (r64277) added an extra argument to Port.dispatchOnDisconnect...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4343002: A recent change (r64277) added an extra argument to Port.dispatchOnDisconnect... (Closed)

Created:
10 years, 1 month ago by Roger Tawa OOO till Jul 10th

Modified:
9 years, 7 months ago

Reviewers:
jstritar

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

A recent change (r64277) added an extra argument to Port.dispatchOnDisconnect() causing this DCHECK to trigger because it was still checking for the old number of arguments. Changed the DCHECK condition to test for the correct number. BUG=0 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64942

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/automation/extension_port_container.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jstritar

10 years, 1 month ago (2010-11-03 14:59:50 UTC) #2

On 2010/11/02 21:40:46, Roger Tawa wrote:
> 

LGTM. Thanks for catching that.

Expand Messages | Collapse Messages