Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 4341005: move full libvpx tree into deps to include license and gyp... (Closed)

Created:
10 years, 1 month ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

move full libvpx tree into deps to include license and gyp BUG=55165 TEST=tools/licenses.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64996

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -98 lines) Patch
M DEPS View 2 chunks +5 lines, -8 lines 0 comments Download
D third_party/libvpx/libvpx.gyp View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
fbarchard
delete src/third_party/libvpx/libvpx.gyp and src/third_party/libvpx folder. libvpx.gyp is now in deps/third_party/ version 64931
10 years, 1 month ago (2010-11-03 17:43:00 UTC) #1
Tom Finegan
On 2010/11/03 17:43:00, fbarchard wrote: > delete src/third_party/libvpx/libvpx.gyp and src/third_party/libvpx folder. > libvpx.gyp is now ...
10 years, 1 month ago (2010-11-03 17:51:04 UTC) #2
fbarchard
I get a warning WARNING: 'src\third_party\libvpx\include' is no longer part of this client. It is ...
10 years, 1 month ago (2010-11-03 19:39:05 UTC) #3
M-A Ruel
On 2010/11/03 19:39:05, fbarchard wrote: > I get a warning > WARNING: 'src\third_party\libvpx\include' is no ...
10 years, 1 month ago (2010-11-03 19:41:33 UTC) #4
fbarchard
Would it help if I submit as 2 CL's? 1 to delete, and 1 to ...
10 years, 1 month ago (2010-11-03 20:08:22 UTC) #5
M-A Ruel
On 2010/11/03 20:08:22, fbarchard wrote: > Would it help if I submit as 2 CL's? ...
10 years, 1 month ago (2010-11-03 20:22:11 UTC) #6
scherkus (not reviewing)
I'm not clear why we did this and undo our work to maintain a relationship ...
10 years, 1 month ago (2010-11-04 21:31:40 UTC) #7
scherkus (not reviewing)
ohhhhhhhhhh wait I thought we were doing the _opposite_ (moving all of libvpx into src/third_party) ...
10 years, 1 month ago (2010-11-04 21:49:57 UTC) #8
fbarchard
10 years, 1 month ago (2010-11-04 21:54:40 UTC) #9
no... same as ffmpeg... move everything into deps
turned into a huge headache of svn and build bots not liking the delete and
deps change
now its just humans complaining... it seems to take more than one delete and
sync

On Thu, Nov 4, 2010 at 2:49 PM, <scherkus@chromium.org> wrote:

> ohhhhhhhhhh wait I thought we were doing the _opposite_ (moving all of
> libvpx
> into src/third_party)
>
> my mistake!  carry on :)
>
>
> http://codereview.chromium.org/4341005/show
>

Powered by Google App Engine
This is Rietveld 408576698