Issue 4341003: Ignore zlib:inflate under TSan...

Issue 4341003: Ignore zlib:inflate under TSan... (Closed)

Created:
10 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Ignore zlib:inflate under TSan This would suppress reports like: http://build.chromium.org/p/chromium.fyi/builders/Linux%20Tests%20(tsan%20ui)/builds/259/steps/memory%20test:%20ui_9/logs/stdio ==14031== WARNING: Possible data race during read of size 4 at 0x801497C: {{{ ==14031== T0 (L{L37, L165}): ==14031== #0 ???//usr/lib/pango/1.6.0/modules/pango-arabic-lang.so /usr/lib/pango/1.6.0/modules/pango-arabic-lang.so ==14031== #1 pthread_mutex_lock /tmp/valgrind-src/tsan/tsan/ts_valgrind_intercepts.c:892 ==14031== #2 dlopen_doit /lib/tls/i686/cmov/libdl-2.7.so ==14031== #3 _dlerror_run /lib/tls/i686/cmov/libdl-2.7.so ... ==14031== Concurrent write(s) happened at (OR AFTER) these points: ==14031== T8 (Chrome_IOThread) (L{}): ==14031== #0 inflate_fast /build/buildd/zlib-1.2.3.3.dfsg/inffast.c:270 ==14031== #1 inflate /build/buildd/zlib-1.2.3.3.dfsg/inflate.c:954 ==14031== #2 GZipFilter::DoInflate(char*, int*) net/base/gzip_filter.cc:226 ==14031== #3 GZipFilter::ReadFilteredData(char*, int*) net/base/gzip_filter.cc:141 This may also speed TSan up a little bit. TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64898

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/valgrind/tsan/ignores.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 1 month ago (2010-11-03 09:19:02 UTC) #2

LGTM

On Wed, Nov 3, 2010 at 12:16 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Ignore zlib:inflate under TSan
>
> This would suppress reports like:
>
http://build.chromium.org/p/chromium.fyi/builders/Linux%20Tests%20(tsan%20ui)...
> ==14031== WARNING: Possible data race during read of size 4 at 0x801497C:
> {{{
> ==14031==    T0 (L{L37, L165}):
> ==14031==     #0  ???//usr/lib/pango/1.6.0/modules/pango-arabic-lang.so
> /usr/lib/pango/1.6.0/modules/pango-arabic-lang.so
> ==14031==     #1  pthread_mutex_lock
> /tmp/valgrind-src/tsan/tsan/ts_valgrind_intercepts.c:892
> ==14031==     #2  dlopen_doit /lib/tls/i686/cmov/libdl-2.7.so
> ==14031==     #3  _dlerror_run /lib/tls/i686/cmov/libdl-2.7.so
> ...
> ==14031==   Concurrent write(s) happened at (OR AFTER) these points:
> ==14031==    T8 (Chrome_IOThread) (L{}):
> ==14031==     #0  inflate_fast /build/buildd/zlib-1.2.3.3.dfsg/inffast.c:270
> ==14031==     #1  inflate /build/buildd/zlib-1.2.3.3.dfsg/inflate.c:954
> ==14031==     #2  GZipFilter::DoInflate(char*, int*)
> net/base/gzip_filter.cc:226
> ==14031==     #3  GZipFilter::ReadFilteredData(char*, int*)
> net/base/gzip_filter.cc:141
>
> This may also speed TSan up a little bit.
>
> TBR=glider
>
> Please review this at http://codereview.chromium.org/4341003/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/tsan/ignores.txt
>
>
> Index: tools/valgrind/tsan/ignores.txt
> ===================================================================
> --- tools/valgrind/tsan/ignores.txt     (revision 64737)
> +++ tools/valgrind/tsan/ignores.txt     (working copy)
> @@ -101,3 +101,6 @@
>  # There is a benign race which is hard to suppress properly,
>  # see http://crbug.com/44580
>  fun_r:*BrowserThread*GetCurrentThreadIdentifier*
> +
> +# zlib is smarter than we are, see http://www.zlib.net/zlib_faq.html#faq36
> +fun_r:inflate
>
>
>

Expand Messages | Collapse Messages