Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 434080: DevTools: provisional implementation of new methods in WebDevToolsAgent (Closed)

Created:
11 years ago by yurys
Modified:
9 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

DevTools: provisional implementation of new methods in WebDevToolsAgent in https://bugs.webkit.org/show_bug.cgi?id=31832 This method will allow to propagate resource load notifications from plugins to InspectorController. BUG=2084 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33292

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove *ForPugin suffix #

Patch Set 3 : address reviewer comments #

Patch Set 4 : Retrieve active DocumentLoader from the frame and pass it to IC #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M webkit/glue/webdevtoolsagent_impl.cc View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
11 years ago (2009-11-25 17:49:55 UTC) #1
pfeldman
http://codereview.chromium.org/434080/diff/1/2 File webkit/glue/webdevtoolsagent_impl.cc (right): http://codereview.chromium.org/434080/diff/1/2#newcode487 webkit/glue/webdevtoolsagent_impl.cc:487: web_view_impl_->mainFrameImpl()->frame()->loader()->documentLoader(), Will this work right for resources loaded for ...
11 years ago (2009-11-25 18:04:38 UTC) #2
yurys
http://codereview.chromium.org/434080/diff/1/2 File webkit/glue/webdevtoolsagent_impl.cc (right): http://codereview.chromium.org/434080/diff/1/2#newcode487 webkit/glue/webdevtoolsagent_impl.cc:487: web_view_impl_->mainFrameImpl()->frame()->loader()->documentLoader(), On 2009/11/25 18:04:38, pfeldman wrote: > Will this ...
11 years ago (2009-11-26 12:23:37 UTC) #3
pfeldman
11 years ago (2009-11-26 12:40:09 UTC) #4
LG

Powered by Google App Engine
This is Rietveld 408576698