Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: chrome/browser/views/browser_actions_container.cc

Issue 434046: Support for chrome.experimental.popup API in ExternalTabContainer views (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/browser_actions_container.cc
===================================================================
--- chrome/browser/views/browser_actions_container.cc (revision 34039)
+++ chrome/browser/views/browser_actions_container.cc (working copy)
@@ -8,6 +8,8 @@
#include "app/resource_bundle.h"
#include "base/stl_util-inl.h"
#include "base/string_util.h"
+#include "chrome/browser/browser.h"
+#include "chrome/browser/browser_window.h"
#include "chrome/browser/extensions/extension_browser_event_router.h"
#include "chrome/browser/extensions/extensions_service.h"
#include "chrome/browser/extensions/extension_tabs_module.h"
@@ -376,8 +378,13 @@
gfx::Rect rect = button->bounds();
rect.set_x(origin.x());
rect.set_y(origin.y());
+
+ gfx::NativeWindow frame_window =
+ toolbar_->browser()->window()->GetNativeHandle();
popup_ = ExtensionPopup::Show(browser_action->popup_url(),
toolbar_->browser(),
+ toolbar_->browser()->profile(),
+ frame_window,
rect,
BubbleBorder::TOP_RIGHT,
true); // Activate the popup window.

Powered by Google App Engine
This is Rietveld 408576698