Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_host.h

Issue 434046: Support for chrome.experimental.popup API in ExternalTabContainer views (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_function_dispatcher.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | chrome/browser/tab_contents/tab_contents_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_host.h
===================================================================
--- chrome/browser/extensions/extension_host.h (revision 34039)
+++ chrome/browser/extensions/extension_host.h (working copy)
@@ -65,7 +65,10 @@
void* view() const { return NULL; }
#endif
- // Create an ExtensionView and tie it to this host and |browser|.
+ // Create an ExtensionView and tie it to this host and |browser|. Note NULL
+ // is a valid argument for |browser|. Extension views may be bound to
+ // tab-contents hosted in ExternalTabContainer objects, which do not
+ // instantiate Browser objects.
void CreateView(Browser* browser);
Extension* extension() { return extension_; }
@@ -173,7 +176,7 @@
// If this ExtensionHost has a view, this returns the Browser that view is a
// part of. If this is a global background page, we use the active Browser
// instead.
- virtual Browser* GetBrowser();
+ virtual Browser* GetBrowser() const;
virtual ExtensionHost* GetExtensionHost() { return this; }
// ExtensionPopupHost::Delegate
« no previous file with comments | « chrome/browser/extensions/extension_function_dispatcher.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | chrome/browser/tab_contents/tab_contents_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698