Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: chrome/browser/extensions/extension_popup_host.h

Issue 434046: Support for chrome.experimental.popup API in ExternalTabContainer views (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_popup_host.h
===================================================================
--- chrome/browser/extensions/extension_popup_host.h (revision 34039)
+++ chrome/browser/extensions/extension_popup_host.h (working copy)
@@ -36,12 +36,14 @@
class PopupDelegate {
public:
PopupDelegate() {}
- virtual ~PopupDelegate() {}
- virtual Browser* GetBrowser() = 0;
+ virtual ~PopupDelegate();
+ virtual Browser* GetBrowser() const = 0;
virtual RenderViewHost* GetRenderViewHost() = 0;
+ virtual Profile* GetProfile();
// Constructs, or returns the existing ExtensionPopupHost instance.
ExtensionPopupHost* popup_host();
+
private:
scoped_ptr<ExtensionPopupHost> popup_host_;
@@ -51,6 +53,8 @@
explicit ExtensionPopupHost(PopupDelegate* delegate);
virtual ~ExtensionPopupHost();
+ void RevokeDelegate() { delegate_ = NULL; }
+
// Dismiss the hosted pop-up, if one is present.
void DismissPopup();

Powered by Google App Engine
This is Rietveld 408576698