Support for chrome.experimental.popup API in ExternalTabContainer views

chrome/browser/extensions/extension_popup_host.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_popup_host.h"
 
 #if defined(TOOLKIT_VIEWS)
 #include "chrome/browser/extensions/extension_popup_api.h"
 #endif
 #include "chrome/browser/profile.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #if defined(TOOLKIT_VIEWS)
 #include "chrome/browser/views/extensions/extension_popup.h"
 #endif
 #include "chrome/common/notification_details.h"
 #include "chrome/common/notification_source.h"
 #include "chrome/common/notification_type.h"
 
 
+ExtensionPopupHost::PopupDelegate::~PopupDelegate() {
+  // If the PopupDelegate is being torn down, then make sure to reset the
+  // cached pointer in the host to prevent access to a stale pointer.
+  if (popup_host_.get())
+    popup_host_->RevokeDelegate();
+}
+
 ExtensionPopupHost* ExtensionPopupHost::PopupDelegate::popup_host() {
   if (!popup_host_.get())
     popup_host_.reset(new ExtensionPopupHost(this));
 
   return popup_host_.get();
 }
 
+Profile* ExtensionPopupHost::PopupDelegate::GetProfile() {
+  // If there is a browser present, return the profile associated with it.
+  // When hosting a view in an ExternalTabContainer, it is possible to have
+  // no Browser instance.
+  Browser* browser = GetBrowser();
+  if (browser) {
+    return browser->profile();
+  }
+
+  return NULL;
+}
+
 ExtensionPopupHost::ExtensionPopupHost(PopupDelegate* delegate)
     :  // NO LINT
 #if defined(TOOLKIT_VIEWS)
       child_popup_(NULL),
 #endif
       delegate_(delegate) {
   DCHECK(delegate_);
 
   // Listen for view close requests, so that we can dismiss a hosted pop-up
   // view, if necessary.
+  Profile* profile = delegate_->GetProfile();
+  DCHECK(profile);
   registrar_.Add(this, NotificationType::EXTENSION_HOST_VIEW_SHOULD_CLOSE,
-                 Source<Profile>(delegate_->GetBrowser()->profile()));
+                 Source<Profile>(profile));
 }
 
 ExtensionPopupHost::~ExtensionPopupHost() {
   DismissPopup();
 }
 
 #if defined(TOOLKIT_VIEWS)
 void ExtensionPopupHost::BubbleBrowserWindowMoved(BrowserBubble* bubble) {
   DismissPopup();
 }
@@ skipping 31 matching lines @@
 }
 
 void ExtensionPopupHost::DismissPopup() {
 #if defined(TOOLKIT_VIEWS)
   if (child_popup_) {
     child_popup_->Hide();
     child_popup_->DetachFromBrowser();
     delete child_popup_;
     child_popup_ = NULL;
 
-    PopupEventRouter::OnPopupClosed(
-        delegate_->GetBrowser()->profile(),
-        delegate_->GetRenderViewHost()->routing_id());
+    if (delegate_) {
+      PopupEventRouter::OnPopupClosed(
+          delegate_->GetProfile(),
+          delegate_->GetRenderViewHost()->routing_id());
+    }
   }
 #endif  // defined(TOOLKIT_VIEWS)
 }