Increasing the default DB quota for extensions from 5MB to 50MB....

Increasing the default DB quota for extensions from 5MB to 50MB.

TEST=none
BUG=none



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32883

[michaeln, 2009-11-23 20:22:33]

http://codereview.chromium.org/434017/diff/1/2
File webkit/database/database_tracker.cc (right):

http://codereview.chromium.org/434017/diff/1/2#newcode28
webkit/database/database_tracker.cc:28: const string16
kExtensionOriginIdentifierPreffix =
nit: spelling preffix

http://codereview.chromium.org/434017/diff/1/2#newcode235
webkit/database/database_tracker.cc:235: if
(!origin_identifier.find(kExtensionOriginIdentifierPreffix))
can you use StartsWith here instead to make sure it really is an extension
origin

[dumi, 2009-11-23 20:47:34]

http://codereview.chromium.org/434017/diff/1/2
File webkit/database/database_tracker.cc (right):

http://codereview.chromium.org/434017/diff/1/2#newcode28
webkit/database/database_tracker.cc:28: const string16
kExtensionOriginIdentifierPreffix =
On 2009/11/23 20:22:33, michaeln wrote:
> nit: spelling preffix

fixed.

http://codereview.chromium.org/434017/diff/1/2#newcode235
webkit/database/database_tracker.cc:235: if
(!origin_identifier.find(kExtensionOriginIdentifierPreffix))
On 2009/11/23 20:22:33, michaeln wrote:
> can you use StartsWith here instead to make sure it really is an extension
> origin

done.

[michaeln, 2009-11-23 21:42:36]

http://codereview.chromium.org/434017/diff/5/6
File webkit/database/database_tracker.cc (right):

http://codereview.chromium.org/434017/diff/5/6#newcode28
webkit/database/database_tracker.cc:28: const string16
kExtensionOriginIdentifierPrefix =
please use a c primitive data-type here to avoid a ctor at library load time

[dumi, 2009-11-23 22:35:18]

http://codereview.chromium.org/434017/diff/5/6
File webkit/database/database_tracker.cc (right):

http://codereview.chromium.org/434017/diff/5/6#newcode28
webkit/database/database_tracker.cc:28: const string16
kExtensionOriginIdentifierPrefix =
On 2009/11/23 21:42:37, michaeln wrote:
> please use a c primitive data-type here to avoid a ctor at library load time

done.

[michaeln, 2009-11-23 22:47:13]

LGTM