Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2794)

Unified Diff: remoting/jingle_glue/ssl_socket_adapter.cc

Issue 4339001: Correctly handle SSL Client Authentication requests when connecting... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: use HostPortPair instead of host,port Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/jingle_glue/ssl_socket_adapter.cc
===================================================================
--- remoting/jingle_glue/ssl_socket_adapter.cc (revision 65819)
+++ remoting/jingle_glue/ssl_socket_adapter.cc (working copy)
@@ -7,6 +7,7 @@
#include "base/compiler_specific.h"
#include "base/message_loop.h"
#include "net/base/address_list.h"
+#include "net/base/host_port_pair.h"
#include "net/base/net_errors.h"
#include "net/base/ssl_config_service.h"
#include "net/base/sys_addrinfo.h"
@@ -67,8 +68,8 @@
transport_socket_->set_addr(talk_base::SocketAddress(hostname_, 0));
ssl_socket_.reset(
net::ClientSocketFactory::GetDefaultFactory()->CreateSSLClientSocket(
- transport_socket_, hostname_.c_str(), ssl_config,
- NULL /* ssl_host_info */));
+ transport_socket_, net::HostPortPair(hostname_, /*TODO(rch)*/443),
wtc 2010/11/12 00:12:55 I think you can remove the TODO comment. It shoul
Ryan Hamilton 2010/11/12 00:47:30 Done.
+ ssl_config, NULL /* ssl_host_info */));
int result = ssl_socket_->Connect(&connected_callback_);
« remoting/jingle_glue/ssl_socket_adapter.h ('K') | « remoting/jingle_glue/ssl_socket_adapter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698