Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket_stream/socket_stream.cc

Issue 4339001: Correctly handle SSL Client Authentication requests when connecting... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: use HostPortPair instead of host,port Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/ssl_client_socket_win.h ('K') | « net/socket/tcp_client_socket_pool_unittest.cc ('k') | remoting/jingle_glue/ssl_socket_adapter.h » ('j') | remoting/jingle_glue/ssl_socket_adapter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream.cc
===================================================================
--- net/socket_stream/socket_stream.cc (revision 65819)
+++ net/socket_stream/socket_stream.cc (working copy)
@@ -798,8 +798,9 @@
DCHECK(factory_);
// TODO(agl): look into plumbing SSLHostInfo here.
socket_.reset(factory_->CreateSSLClientSocket(
- socket_.release(), url_.HostNoBrackets(), ssl_config_,
- NULL /* ssl_host_info */));
+ socket_.release(),
+ HostPortPair(url_.HostNoBrackets(), url_.EffectiveIntPort()),
+ ssl_config_, NULL /* ssl_host_info */));
next_state_ = STATE_SSL_CONNECT_COMPLETE;
metrics_->OnSSLConnection();
return socket_->Connect(&io_callback_);
« net/socket/ssl_client_socket_win.h ('K') | « net/socket/tcp_client_socket_pool_unittest.cc ('k') | remoting/jingle_glue/ssl_socket_adapter.h » ('j') | remoting/jingle_glue/ssl_socket_adapter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698