Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_network_transaction.cc

Issue 4339001: Correctly handle SSL Client Authentication requests when connecting... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: use HostPortPair instead of host,port Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« jingle/notifier/base/chrome_async_socket.h ('K') | « jingle/notifier/base/xmpp_client_socket_factory.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | net/socket/ssl_client_socket_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
===================================================================
--- net/http/http_network_transaction.cc (revision 65819)
+++ net/http/http_network_transaction.cc (working copy)
@@ -172,8 +172,8 @@
ssl_config_.client_cert = client_cert;
if (client_cert) {
- session_->ssl_client_auth_cache()->Add(GetHostAndPort(request_->url),
- client_cert);
+ session_->ssl_client_auth_cache()->Add(
+ response_.cert_request_info->host_and_port, client_cert);
}
ssl_config_.send_client_cert = true;
// Reset the other member variables.
@@ -973,8 +973,8 @@
// If the user selected one of the certificate in client_certs for this
// server before, use it automatically.
- X509Certificate* client_cert = session_->ssl_client_auth_cache()->
- Lookup(GetHostAndPort(request_->url));
+ X509Certificate* client_cert = session_->ssl_client_auth_cache()->Lookup(
+ response_.cert_request_info->host_and_port);
if (client_cert) {
const std::vector<scoped_refptr<X509Certificate> >& client_certs =
response_.cert_request_info->client_certs;
« jingle/notifier/base/chrome_async_socket.h ('K') | « jingle/notifier/base/xmpp_client_socket_factory.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | net/socket/ssl_client_socket_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698