Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: net/socket/ssl_client_socket_win.h

Issue 4339001: Correctly handle SSL Client Authentication requests when connecting... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressing eroman's feedback Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_unittest.cc ('k') | net/socket/ssl_client_socket_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_win.h
===================================================================
--- net/socket/ssl_client_socket_win.h (revision 65819)
+++ net/socket/ssl_client_socket_win.h (working copy)
@@ -17,25 +17,29 @@
#include "base/scoped_ptr.h"
#include "net/base/cert_verify_result.h"
#include "net/base/completion_callback.h"
+#include "net/base/host_port_pair.h"
#include "net/base/net_log.h"
#include "net/base/ssl_config_service.h"
#include "net/socket/ssl_client_socket.h"
namespace net {
+class BoundNetLog;
class CertVerifier;
class ClientSocketHandle;
-class BoundNetLog;
+class HostPortPair;
// An SSL client socket implemented with the Windows Schannel.
class SSLClientSocketWin : public SSLClientSocket {
public:
// Takes ownership of the |transport_socket|, which must already be connected.
- // The given hostname will be compared with the name(s) in the server's
- // certificate during the SSL handshake. ssl_config specifies the SSL
- // settings.
+ // The hostname specified in |host_and_port| will be compared with the name(s)
+ // in the server's certificate during the SSL handshake. If SSL client
+ // authentication is requested, the host_and_port field of SSLCertRequestInfo
+ // will be populated with |host_and_port|. |ssl_config| specifies
+ // the SSL settings.
SSLClientSocketWin(ClientSocketHandle* transport_socket,
- const std::string& hostname,
+ const HostPortPair& host_and_port,
const SSLConfig& ssl_config);
~SSLClientSocketWin();
@@ -103,7 +107,7 @@
CompletionCallbackImpl<SSLClientSocketWin> write_callback_;
scoped_ptr<ClientSocketHandle> transport_;
- std::string hostname_;
+ HostPortPair host_and_port_;
SSLConfig ssl_config_;
// User function to callback when the Connect() completes.
« no previous file with comments | « net/socket/ssl_client_socket_unittest.cc ('k') | net/socket/ssl_client_socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698