net/socket/ssl_client_socket_unittest.cc - Issue 4339001: Correctly handle SSL Client Authentication requests when connecting...

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 4339001: Correctly handle SSL Client Authentication requests when connecting... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Addressing eroman's feedback Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_unittest.cc

===================================================================

--- net/socket/ssl_client_socket_unittest.cc (revision 65819)

+++ net/socket/ssl_client_socket_unittest.cc (working copy)

@@ -67,8 +67,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -105,8 +104,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -145,8 +143,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -189,8 +186,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -232,8 +228,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), ssl_config,

- NULL));

+ transport, test_server.host_port_pair(), ssl_config, NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -275,8 +270,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

rv = sock->Connect(&callback);

if (rv == net::ERR_IO_PENDING)

@@ -331,8 +325,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

rv = sock->Connect(&callback);

if (rv == net::ERR_IO_PENDING)

@@ -386,8 +379,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

rv = sock->Connect(&callback);

if (rv == net::ERR_IO_PENDING)

@@ -437,8 +429,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

rv = sock->Connect(&callback);

if (rv == net::ERR_IO_PENDING)

@@ -508,8 +499,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

- NULL));

+ transport, test_server.host_port_pair(), kDefaultSSLConfig, NULL));

rv = sock->Connect(&callback);

EXPECT_EQ(net::ERR_SSL_PROTOCOL_ERROR, rv);

@@ -558,8 +548,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(),

- ssl_config, NULL));

+ transport, test_server.host_port_pair(), ssl_config, NULL));

EXPECT_FALSE(sock->IsConnected());

« no previous file with comments | « net/socket/ssl_client_socket_snapstart_unittest.cc ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »