Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: net/socket/client_socket_factory.cc

Issue 4339001: Correctly handle SSL Client Authentication requests when connecting... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressing eroman's feedback Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/client_socket_factory.h ('k') | net/socket/client_socket_pool_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_factory.cc
===================================================================
--- net/socket/client_socket_factory.cc (revision 65819)
+++ net/socket/client_socket_factory.cc (working copy)
@@ -27,20 +27,21 @@
SSLClientSocket* DefaultSSLClientSocketFactory(
ClientSocketHandle* transport_socket,
- const std::string& hostname,
+ const HostPortPair& host_and_port,
const SSLConfig& ssl_config,
SSLHostInfo* ssl_host_info,
DnsRRResolver* dnsrr_resolver) {
scoped_ptr<SSLHostInfo> shi(ssl_host_info);
#if defined(OS_WIN)
- return new SSLClientSocketWin(transport_socket, hostname, ssl_config);
+ return new SSLClientSocketWin(transport_socket, host_and_port, ssl_config);
#elif defined(USE_OPENSSL)
- return new SSLClientSocketOpenSSL(transport_socket, hostname, ssl_config);
+ return new SSLClientSocketOpenSSL(transport_socket, host_and_port,
+ ssl_config);
#elif defined(USE_NSS)
- return new SSLClientSocketNSS(transport_socket, hostname, ssl_config,
+ return new SSLClientSocketNSS(transport_socket, host_and_port, ssl_config,
shi.release(), dnsrr_resolver);
#elif defined(OS_MACOSX)
- return new SSLClientSocketNSS(transport_socket, hostname, ssl_config,
+ return new SSLClientSocketNSS(transport_socket, host_and_port, ssl_config,
shi.release(), dnsrr_resolver);
#else
NOTIMPLEMENTED();
@@ -61,12 +62,12 @@
virtual SSLClientSocket* CreateSSLClientSocket(
ClientSocketHandle* transport_socket,
- const std::string& hostname,
+ const HostPortPair& host_and_port,
const SSLConfig& ssl_config,
SSLHostInfo* ssl_host_info,
DnsRRResolver* dnsrr_resolver) {
- return g_ssl_factory(transport_socket, hostname, ssl_config, ssl_host_info,
- dnsrr_resolver);
+ return g_ssl_factory(transport_socket, host_and_port, ssl_config,
+ ssl_host_info, dnsrr_resolver);
}
};
@@ -86,12 +87,12 @@
// Deprecated function (http://crbug.com/37810) that takes a ClientSocket.
SSLClientSocket* ClientSocketFactory::CreateSSLClientSocket(
ClientSocket* transport_socket,
- const std::string& hostname,
+ const HostPortPair& host_and_port,
const SSLConfig& ssl_config,
SSLHostInfo* ssl_host_info) {
ClientSocketHandle* socket_handle = new ClientSocketHandle();
socket_handle->set_socket(transport_socket);
- return CreateSSLClientSocket(socket_handle, hostname, ssl_config,
+ return CreateSSLClientSocket(socket_handle, host_and_port, ssl_config,
ssl_host_info, NULL /* DnsRRResolver */);
}
« no previous file with comments | « net/socket/client_socket_factory.h ('k') | net/socket/client_socket_pool_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698