Correctly handle SSL Client Authentication requests when connecting...

jingle/notifier/base/chrome_async_socket.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/notifier/base/chrome_async_socket.h"
 
 #if defined(OS_WIN)
 #include <winsock2.h>
 #elif defined(OS_POSIX)
 #include <arpa/inet.h>
@@ skipping 417 matching lines @@
   read_start_ = 0U;
   read_end_ = 0U;
   DCHECK_EQ(write_end_, 0U);
 
   // Clear out any posted DoRead() tasks.
   scoped_runnable_method_factory_.RevokeAll();
 
   DCHECK(transport_socket_.get());
   transport_socket_.reset(
       client_socket_factory_->CreateSSLClientSocket(
-          transport_socket_.release(), domain_name, ssl_config_,
-          NULL /* ssl_host_info */));
+          transport_socket_.release(), domain_name, /*TODO(rch)*/-1,

[wtc, 2010/11/11 01:11:35]

Please pass 443 instead of -1 as the temporary port value.

(I think 443 is the correct value, and you can remove
the TODO comment.)

[Ryan Hamilton, 2010/11/11 18:57:00]

Done.

+          ssl_config_, NULL /* ssl_host_info */));
   int status = transport_socket_->Connect(&ssl_connect_callback_);
   if (status != net::ERR_IO_PENDING) {
     MessageLoop* message_loop = MessageLoop::current();
     CHECK(message_loop);
     message_loop->PostTask(
         FROM_HERE,
         scoped_runnable_method_factory_.NewRunnableMethod(
             &ChromeAsyncSocket::ProcessSSLConnectDone, status));
   }
   return true;
@@ skipping 18 matching lines @@
   }
   state_ = STATE_TLS_OPEN;
   PostDoRead();
   if (write_end_ > 0U) {
     PostDoWrite();
   }
   SignalSSLConnected();
 }
 
 }  // namespace notifier