Issue 4337001: Fix 2 accessibility events that were not being sent with the appro...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4337001: Fix 2 accessibility events that were not being sent with the appro... (Closed)

Created:
10 years, 1 month ago by kkania

Modified:
9 years, 7 months ago

Reviewers:
Chris Guillory

CC:
chromium-reviews, ben+cc_chromium.org, David Tseng, dmazzoni

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix 2 accessibility events that were not being sent with the appropriate accessibility object. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64967

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/accessibility/browser_accessibility_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

LGTM. Thanks for catching this. We will needed to get some tests in for this.

10 years, 1 month ago (2010-11-02 21:00:26 UTC) #2

Chris Guillory

Looks like this wasn't submitted yet. I had incorporated it into a change I working ...

10 years, 1 month ago (2010-11-03 19:13:28 UTC) #3

Chris Guillory

On 2010/11/03 19:13:28, Chris Guillory wrote: > Looks like this wasn't submitted yet. I had ...

10 years, 1 month ago (2010-11-03 21:34:31 UTC) #4

kkania

10 years, 1 month ago (2010-11-03 21:43:16 UTC) #5

On 2010/11/03 21:34:31, Chris Guillory wrote:
> On 2010/11/03 19:13:28, Chris Guillory wrote:
> > Looks like this wasn't submitted yet. I had incorporated it into a change I
> > working on and just submitted that.
> Oops. Looks like I didn't actually incorporate this into my previous change.
Can
> you submit this Ken?

Sure, I'll submit it now.

Expand Messages | Collapse Messages