Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: base/pe_image_unittest.cc

Issue 4335: Silence this unit test on Windows 2003 until bug 2732 is fixed. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/pe_image_unittest.cc
===================================================================
--- base/pe_image_unittest.cc (revision 2669)
+++ base/pe_image_unittest.cc (working copy)
@@ -6,6 +6,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "base/pe_image.h"
+#include "base/win_util.h"
// Just counts the number of invocations.
bool ExportsCallback(const PEImage &image,
@@ -137,6 +138,11 @@
// Tests that we are able to enumerate stuff from a PE file, and that
// the actual number of items found is within the expected range.
TEST(PEImageTest, EnumeratesPE) {
+ // TODO(rvargas): Quick workaround until this issue is fixed:
+ // http://code.google.com/p/chromium/issues/detail?id=2732
+ // Note that this bug is about Windows 2003 x64, not Win2k3 in general.
+ if (win_util::GetWinVersion() == win_util::WINVERSION_SERVER_2003)
+ return;
HMODULE module = LoadLibrary(L"advapi32.dll");
ASSERT_TRUE(NULL != module);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698