Delete user image when user is removed.

Delete user image when user is removed.

BUG=chromium-os:8161
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64915

[whywhat, 2010-11-03 12:45:03]

http://codereview.chromium.org/4332002/diff/2002/4001
File chrome/browser/chromeos/login/user_manager.cc (right):

http://codereview.chromium.org/4332002/diff/2002/4001#newcode105
chrome/browser/chromeos/login/user_manager.cc:105: if
(!file_util::PathExists(image_path))
Maybe you don't need this check?

http://codereview.chromium.org/4332002/diff/2002/4001#newcode109
chrome/browser/chromeos/login/user_manager.cc:109: return;
Don't think you need return here

http://codereview.chromium.org/4332002/diff/2002/4001#newcode413
chrome/browser/chromeos/login/user_manager.cc:413: *image_path =
user_data_dir.AppendASCII(filename);
Why not simply return FilePath object?

[altimofeev, 2010-11-03 13:59:21]

http://codereview.chromium.org/4332002/diff/2002/4001
File chrome/browser/chromeos/login/user_manager.cc (right):

http://codereview.chromium.org/4332002/diff/2002/4001#newcode105
chrome/browser/chromeos/login/user_manager.cc:105: if
(!file_util::PathExists(image_path))
On 2010/11/03 12:45:04, whywhat wrote:
> Maybe you don't need this check?

Removed.

http://codereview.chromium.org/4332002/diff/2002/4001#newcode109
chrome/browser/chromeos/login/user_manager.cc:109: return;
On 2010/11/03 12:45:04, whywhat wrote:
> Don't think you need return here

Just in case someone will extend the method and forget to add it.

http://codereview.chromium.org/4332002/diff/2002/4001#newcode413
chrome/browser/chromeos/login/user_manager.cc:413: *image_path =
user_data_dir.AppendASCII(filename);
On 2010/11/03 12:45:04, whywhat wrote:
> Why not simply return FilePath object?

As always - to avoid unnecessary copying.
Anyway, changed to return FilePath.

[whywhat, 2010-11-03 14:32:12]

LGTM