Issue 4327001: Open tab in the correct location from a tab's context menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4327001: Open tab in the correct location from a tab's context menu. (Closed)

Created:
10 years, 1 month ago by sadrul

Modified:
9 years, 6 months ago

Reviewers:
sky, Ben Goodger (Google)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Open tab in the correct location from a tab's context menu. BUG=59146 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64957

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/tabs/tab_strip_model.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

The bug was initially fixed by revision 63890, but broke with 64745.

10 years, 1 month ago (2010-11-02 20:17:57 UTC) #1

sky

http://codereview.chromium.org/4327001/diff/1/2 File chrome/browser/tabs/tab_strip_model.cc (right): http://codereview.chromium.org/4327001/diff/1/2#newcode647 chrome/browser/tabs/tab_strip_model.cc:647: delegate()->AddBlankTabAt(context_index + 1, true); I tend to think the ...

10 years, 1 month ago (2010-11-02 22:39:17 UTC) #2

Ben told me I'm wrong.
LGTM

Expand Messages | Collapse Messages