Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: gclient_utils.py

Issue 4321006: Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | presubmit_canned_checks.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index ecc59cc7f6555bd5a6ca8b0d1bfd61518bf5c4a3..d0fbb1ef73431b4980f929b735aee80a8a3f8c16 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -316,6 +316,8 @@ def MakeFileAutoFlush(fileobj, delay=10):
fileobj.delay = delay
return fileobj
+ # Attribute 'XXX' defined outside __init__
+ # pylint: disable=W0201
new_fileobj = SoftClone(fileobj)
if not hasattr(new_fileobj, 'lock'):
new_fileobj.lock = threading.Lock()
@@ -350,6 +352,8 @@ def MakeFileAnnotated(fileobj):
# Already patched.
return fileobj
+ # Attribute 'XXX' defined outside __init__
+ # pylint: disable=W0201
new_fileobj = SoftClone(fileobj)
if not hasattr(new_fileobj, 'lock'):
new_fileobj.lock = threading.Lock()
@@ -698,6 +702,8 @@ class ExecutionQueue(object):
"""Runs in its own thread."""
logging.debug('running(%s)' % self.item.name)
work_queue = self.kwargs['work_queue']
+ # It's necessary to catch all exceptions.
+ # pylint: disable=W0703
try:
self.item.run(*self.args, **self.kwargs)
except Exception:
« no previous file with comments | « gclient.py ('k') | presubmit_canned_checks.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698