Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT.

gclient_utils.py

 # Copyright 2009 Google Inc.  All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #      http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 298 matching lines @@
   return new_obj
 
 
 def MakeFileAutoFlush(fileobj, delay=10):
   """Creates a file object clone to automatically flush after N seconds."""
   if hasattr(fileobj, 'last_flushed_at'):
     # Already patched. Just update delay.
     fileobj.delay = delay
     return fileobj
 
+  # Attribute 'XXX' defined outside __init__
+  # pylint: disable=W0201
   new_fileobj = SoftClone(fileobj)
   if not hasattr(new_fileobj, 'lock'):
     new_fileobj.lock = threading.Lock()
   new_fileobj.last_flushed_at = time.time()
   new_fileobj.delay = delay
   new_fileobj.old_auto_flush_write = new_fileobj.write
   # Silence pylint.
   new_fileobj.flush = fileobj.flush
 
   def auto_flush_write(out):
@@ skipping 14 matching lines @@
   return new_fileobj
 
 
 def MakeFileAnnotated(fileobj):
   """Creates a file object clone to automatically prepends every line in worker
   threads with a NN> prefix."""
   if hasattr(fileobj, 'output_buffers'):
     # Already patched.
     return fileobj
 
+  # Attribute 'XXX' defined outside __init__
+  # pylint: disable=W0201
   new_fileobj = SoftClone(fileobj)
   if not hasattr(new_fileobj, 'lock'):
     new_fileobj.lock = threading.Lock()
   new_fileobj.output_buffers = {}
   new_fileobj.old_annotated_write = new_fileobj.write
 
   def annotated_write(out):
     index = getattr(threading.currentThread(), 'index', None)
     if index is None:
       # Undexed threads aren't buffered.
@@ skipping 328 matching lines @@
       logging.info(item.name)
       self.item = item
       self.index = index
       self.args = args
       self.kwargs = kwargs
 
     def run(self):
       """Runs in its own thread."""
       logging.debug('running(%s)' % self.item.name)
       work_queue = self.kwargs['work_queue']
+      # It's necessary to catch all exceptions.
+      # pylint: disable=W0703
       try:
         self.item.run(*self.args, **self.kwargs)
       except Exception:
         # Catch exception location.
         logging.info('Caught exception in thread %s' % self.item.name)
         logging.info(str(sys.exc_info()))
         work_queue.exceptions.put(sys.exc_info())
       logging.info('Task %s done' % self.item.name)
 
       work_queue.ready_cond.acquire()
       try:
         work_queue.ready_cond.notifyAll()
       finally:
         work_queue.ready_cond.release()